From 48e13b647a33ad0660a131b0bc72594164befd13 Mon Sep 17 00:00:00 2001 From: Fabian Keil Date: Sun, 28 Jun 2009 18:55:08 +0200 Subject: [PATCH 01/68] Fix a NULL pointer dereference in vcard_build_items(), assuming the check is necessary. --- src/vcard.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/vcard.c b/src/vcard.c index 4ae3dc5..fec0018 100644 --- a/src/vcard.c +++ b/src/vcard.c @@ -345,8 +345,8 @@ static void vcard_build_items( if( *str != '\0' ) { ItemEMail *email = addritem_create_item_email(); addritem_email_set_address( email, str ); - str = nodeRemarks->data; if( nodeRemarks ) { + str = nodeRemarks->data; if( str ) { if( g_utf8_collate( str, "internet" ) != 0 ) { if( *str != '\0' ) -- 1.6.3.3 From 158d4caf4897dccc9459b5257cf4d33229ff5175 Mon Sep 17 00:00:00 2001 From: Fabian Keil Date: Sun, 28 Jun 2009 20:09:54 +0200 Subject: [PATCH 02/68] Fix a NULL pointer dereference in mutt_parse_rcplist() if no closing parenthesis is found. --- src/mutt.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/mutt.c b/src/mutt.c index d6b1dd0..484d567 100644 --- a/src/mutt.c +++ b/src/mutt.c @@ -212,7 +212,7 @@ static GSList *mutt_parse_rcplist( gchar *rcpList, gint *addrCount ) { list = NULL; cnt = 0; pStart = rcpList; - while( *pStart ) { + while( pStart && *pStart ) { ptr = pStart; address = name = NULL; pName = pAddr = NULL; -- 1.6.3.3 From 54a7c2321d1907149b68819a5e40b34c1ef532a7 Mon Sep 17 00:00:00 2001 From: Fabian Keil Date: Sun, 28 Jun 2009 20:45:12 +0200 Subject: [PATCH 03/68] Fix a NULL pointer dereference in inc_finished(). --- src/inc.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/inc.c b/src/inc.c index 4bdeaec..0c0c418 100644 --- a/src/inc.c +++ b/src/inc.c @@ -170,7 +170,7 @@ static void inc_finished(MainWindow *mainwin, gboolean new_messages, gboolean au if (cur_account && cur_account->inbox) item = folder_find_item_from_identifier(cur_account->inbox); - if (item == NULL && cur_account->folder) + if (item == NULL && cur_account && cur_account->folder) item = cur_account->folder->inbox; if (item == NULL) item = folder_get_default_inbox(); -- 1.6.3.3 From effd5cb58d80d608e9ede0c2f6323094b0462594 Mon Sep 17 00:00:00 2001 From: Fabian Keil Date: Sun, 28 Jun 2009 21:00:03 +0200 Subject: [PATCH 04/68] Fix a cm_return_if_fail() condition in addritem_person_remove_attribute(). --- src/addritem.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/addritem.c b/src/addritem.c index 91a45cc..1cfe846 100644 --- a/src/addritem.c +++ b/src/addritem.c @@ -589,7 +589,7 @@ void addritem_person_add_attribute( * \param attrib Attribute to remove. */ void addritem_person_remove_attribute( ItemPerson *person, const gchar *attrib ) { - cm_return_if_fail( person != NULL || attrib != NULL ); + cm_return_if_fail( person != NULL && attrib != NULL ); GList *attrib_list; attrib_list = person->listAttrib; -- 1.6.3.3 From 271e2dc8e351fe53a1ee9bb95802e4e13d8482df Mon Sep 17 00:00:00 2001 From: Fabian Keil Date: Mon, 29 Jun 2009 14:57:41 +0200 Subject: [PATCH 05/68] Fix two NULL pointer dereferences in addressbook_treenode_delete_cb(). --- src/addressbook.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/addressbook.c b/src/addressbook.c index da84a41..e7360c1 100644 --- a/src/addressbook.c +++ b/src/addressbook.c @@ -2926,7 +2926,7 @@ static void addressbook_treenode_delete_cb(GtkAction *action, gpointer data) /* Confirm deletion */ delType = ADDRTREE_DEL_NONE; if( obj->type == ADDR_ITEM_FOLDER ) { - if( iface->externalQuery ) { + if( iface && iface->externalQuery ) { message = g_strdup_printf( _( "Do you want to delete the query " \ "results and addresses in '%s' ?" ), @@ -2989,7 +2989,7 @@ static void addressbook_treenode_delete_cb(GtkAction *action, gpointer data) cache = adbase->addressCache; /* Remove query results folder */ - if( iface->externalQuery ) { + if( iface && iface->externalQuery ) { AdapterFolder *adapter = ADAPTER_FOLDER(obj); ItemFolder *folder = adapter->itemFolder; -- 1.6.3.3 From f5b3637fe9e5a15421012e68dd63956b01ae0728 Mon Sep 17 00:00:00 2001 From: Fabian Keil Date: Mon, 29 Jun 2009 17:03:44 +0200 Subject: [PATCH 06/68] Streamline create_description()'s prototype. It doesn't use pass_hint for anything useful. --- src/plugins/pgpcore/passphrase.c | 13 ++++--------- 1 files changed, 4 insertions(+), 9 deletions(-) diff --git a/src/plugins/pgpcore/passphrase.c b/src/plugins/pgpcore/passphrase.c index c348f6b..1155fc3 100644 --- a/src/plugins/pgpcore/passphrase.c +++ b/src/plugins/pgpcore/passphrase.c @@ -58,8 +58,7 @@ static gint passphrase_deleted(GtkWidget *widget, GdkEventAny *event, static gboolean passphrase_key_pressed(GtkWidget *widget, GdkEventKey *event, gpointer data); -static GtkWidget *create_description(const gchar *uid_hint, - const gchar *pass_hint, gint prev_bad, gint new_key); +static GtkWidget *create_description(const gchar *uid_hint, gint prev_bad, gint new_key); void gpgmegtk_set_passphrase_grab(gint yes) @@ -101,7 +100,7 @@ passphrase_mbox(const gchar *uid_hint, const gchar *pass_hint, gint prev_bad, gi if (uid_hint || pass_hint) { GtkWidget *label, *icon; - label = create_description (uid_hint, pass_hint, prev_bad, new_key); + label = create_description (uid_hint, prev_bad, new_key); icon = gtk_image_new_from_stock(GTK_STOCK_DIALOG_AUTHENTICATION, GTK_ICON_SIZE_DIALOG); @@ -242,9 +241,9 @@ linelen (const gchar *s) } static GtkWidget * -create_description(const gchar *uid_hint, const gchar *pass_hint, gint prev_bad, gint new_key) +create_description(const gchar *uid_hint, gint prev_bad, gint new_key) { - const gchar *uid = NULL, *info = NULL; + const gchar *uid = NULL; gchar *buf; GtkWidget *label; gchar *my_uid = NULL; @@ -252,10 +251,6 @@ create_description(const gchar *uid_hint, const gchar *pass_hint, gint prev_bad, uid = _("[no user id]"); else uid = uid_hint; - if (!pass_hint) - info = ""; - else - info = pass_hint; my_uid = g_strdup(uid); while (strchr(my_uid, '<')) -- 1.6.3.3 From 9a8eff6d1f43f16b9e1cbdd66fe10cb1096c364e Mon Sep 17 00:00:00 2001 From: Fabian Keil Date: Mon, 29 Jun 2009 17:05:42 +0200 Subject: [PATCH 07/68] Remove the write-only variable validity in sgpgme_verify_signature(). --- src/plugins/pgpcore/sgpgme.c | 2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/src/plugins/pgpcore/sgpgme.c b/src/plugins/pgpcore/sgpgme.c index 8410ab0..d256af2 100644 --- a/src/plugins/pgpcore/sgpgme.c +++ b/src/plugins/pgpcore/sgpgme.c @@ -84,7 +84,6 @@ gpgme_verify_result_t sgpgme_verify_signature(gpgme_ctx_t ctx, gpgme_data_t sig, SignatureStatus sgpgme_sigstat_gpgme_to_privacy(gpgme_ctx_t ctx, gpgme_verify_result_t status) { - unsigned long validity = 0; gpgme_signature_t sig = NULL; if (GPOINTER_TO_INT(status) == -GPG_ERR_SYSTEM_ERROR) { @@ -102,7 +101,6 @@ SignatureStatus sgpgme_sigstat_gpgme_to_privacy(gpgme_ctx_t ctx, gpgme_verify_re debug_print("sig == NULL\n"); return SIGNATURE_UNCHECKED; } - validity = sig->validity; debug_print("err code %d\n", gpg_err_code(sig->status)); switch (gpg_err_code(sig->status)) { -- 1.6.3.3 From 9f20f4ac5a5ac6d436944e4bfb511b4803ec249b Mon Sep 17 00:00:00 2001 From: Fabian Keil Date: Mon, 29 Jun 2009 17:20:18 +0200 Subject: [PATCH 08/68] In procmsg_list_sort_by_account(), give nothing_to_sort the chance to be FALSE when it's checked. XXX: This is a guess. --- src/procmsg.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/procmsg.c b/src/procmsg.c index 1daa89a..e3021b0 100644 --- a/src/procmsg.c +++ b/src/procmsg.c @@ -773,7 +773,6 @@ static GSList *procmsg_list_sort_by_account(FolderItem *queue, GSList *list) debug_print("\n"); parse_again: - nothing_to_sort = TRUE; cur = orig; while (cur) { gchar *file = NULL; @@ -790,6 +789,7 @@ parse_again: nothing_to_sort = FALSE; goto parse_again; } + nothing_to_sort = TRUE; cur = cur->next; } -- 1.6.3.3 From 767a1a7855d1ad9446b37d825811c6af014bd011 Mon Sep 17 00:00:00 2001 From: Fabian Keil Date: Sun, 5 Jul 2009 12:36:03 +0200 Subject: [PATCH 09/68] Don't ignore gnutls_certificate_verify_peers2()'s return code. --- src/common/ssl.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/src/common/ssl.c b/src/common/ssl.c index 932a5ab..610d6c3 100644 --- a/src/common/ssl.c +++ b/src/common/ssl.c @@ -318,7 +318,8 @@ gboolean ssl_init_socket_with_method(SockInfo *sockinfo, SSLMethod method) r = gnutls_certificate_verify_peers2(session, &status); - if (!ssl_certificate_check(cert, status, sockinfo->canonical_name, sockinfo->hostname, sockinfo->port)) { + if (r < 0 + || !ssl_certificate_check(cert, status, sockinfo->canonical_name, sockinfo->hostname, sockinfo->port)) { gnutls_x509_crt_deinit(cert); gnutls_certificate_free_credentials(xcred); gnutls_deinit(session); -- 1.6.3.3 From 5f7c194e0ff39745d880f7b8f9209a371cacb76e Mon Sep 17 00:00:00 2001 From: Fabian Keil Date: Sun, 5 Jul 2009 12:36:00 +0200 Subject: [PATCH 10/68] Report if writing to the queue message failed after a problem with the key selection has been detected. --- src/compose.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/src/compose.c b/src/compose.c index 6fe0204..10cc01d 100644 --- a/src/compose.c +++ b/src/compose.c @@ -5672,6 +5672,8 @@ static gint compose_queue_sub(Compose *compose, gint *msgnum, FolderItem **item, err |= (fprintf(fp, "X-Claws-Encrypt:%d\n", compose->use_encryption) < 0); /* and if encdata was null, it means there's been a problem in * key selection */ + if (err == TRUE) + g_warning("failed to write queue message\n"); lock = FALSE; fclose(fp); claws_unlink(tmp); -- 1.6.3.3 From 8d50346ffbb665976ba04622da212c8626c56796 Mon Sep 17 00:00:00 2001 From: Fabian Keil Date: Sun, 5 Jul 2009 12:36:01 +0200 Subject: [PATCH 11/68] Remove code that seems to be dead since r1.35. --- src/mh.c | 6 ------ 1 files changed, 0 insertions(+), 6 deletions(-) diff --git a/src/mh.c b/src/mh.c index 3cfa7a0..3c6593a 100644 --- a/src/mh.c +++ b/src/mh.c @@ -463,7 +463,6 @@ static gint mh_copy_msgs(Folder *folder, FolderItem *dest, MsgInfoList *msglist, FolderItem *src = NULL; gchar *srcfile; gchar *destfile; - gint filemode = 0; FolderItemPrefs *prefs; MsgInfo *msginfo = NULL; MsgInfoList *cur = NULL; @@ -572,11 +571,6 @@ static gint mh_copy_msgs(Folder *folder, FolderItem *dest, MsgInfoList *msglist, if (prefs && prefs->enable_folder_chmod && prefs->folder_chmod) { if (chmod(destfile, prefs->folder_chmod) < 0) FILE_OP_ERROR(destfile, "chmod"); - - /* for mark file */ - filemode = prefs->folder_chmod; - if (filemode & S_IRGRP) filemode |= S_IWGRP; - if (filemode & S_IROTH) filemode |= S_IWOTH; } if (relation) g_relation_insert(relation, msginfo, GINT_TO_POINTER(dest->last_num+1)); -- 1.6.3.3 From e75001db6f62042ca435d2080ea3d7a3ef26c80f Mon Sep 17 00:00:00 2001 From: Fabian Keil Date: Sun, 5 Jul 2009 12:36:04 +0200 Subject: [PATCH 12/68] Not sure about this one, but otherwise w_hbox would have no purpose. --- src/gtk/gtkaspell.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/gtk/gtkaspell.c b/src/gtk/gtkaspell.c index 6957550..7c90c07 100644 --- a/src/gtk/gtkaspell.c +++ b/src/gtk/gtkaspell.c @@ -1403,10 +1403,10 @@ static void replace_with_create_dialog_cb(GtkWidget *w, gpointer data) icon = gtk_image_new_from_stock(GTK_STOCK_DIALOG_QUESTION, GTK_ICON_SIZE_DIALOG); gtk_misc_set_alignment (GTK_MISC (icon), 0.5, 0.0); - gtk_box_pack_start (GTK_BOX (hbox), icon, FALSE, FALSE, 0); + gtk_box_pack_start (GTK_BOX (w_hbox), icon, FALSE, FALSE, 0); vbox = gtk_vbox_new (FALSE, 12); - gtk_box_pack_start (GTK_BOX (hbox), vbox, TRUE, TRUE, 0); + gtk_box_pack_start (GTK_BOX (w_hbox), vbox, TRUE, TRUE, 0); gtk_widget_show (vbox); label = gtk_label_new(thelabel); -- 1.6.3.3 From ae82e3901bca6cfc7819f0835c9d7e6673ca92a5 Mon Sep 17 00:00:00 2001 From: Fabian Keil Date: Sun, 5 Jul 2009 12:36:05 +0200 Subject: [PATCH 13/68] Mark a potential problem in colorize(). --- src/compose.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/src/compose.c b/src/compose.c index 10cc01d..0c16540 100644 --- a/src/compose.c +++ b/src/compose.c @@ -4280,6 +4280,7 @@ colorize: } else walk = scanpos + strlen(parser[last_index].needle); + /* XXX: The values written to walk will not be read. Should they be written to o_walk? */ } if (bp && ep) { uri_start = walk_pos + (bp - o_walk); -- 1.6.3.3 From f4866d5b4117bb4d4c731326c242c9acd2c5d31e Mon Sep 17 00:00:00 2001 From: Fabian Keil Date: Sun, 5 Jul 2009 12:36:05 +0200 Subject: [PATCH 14/68] Remove redundant code. body_fmt will be overwritten anyway, and the same code exists in the else block below. --- src/compose.c | 5 ----- 1 files changed, 0 insertions(+), 5 deletions(-) diff --git a/src/compose.c b/src/compose.c index 0c16540..30a32a5 100644 --- a/src/compose.c +++ b/src/compose.c @@ -1712,11 +1712,6 @@ Compose *compose_forward(PrefsAccount *account, MsgInfo *msginfo, const gchar *body_fmt = NULL; MsgInfo *full_msginfo; - if (prefs_common.fw_quotefmt && *prefs_common.fw_quotefmt) - body_fmt = gettext(prefs_common.fw_quotefmt); - else - body_fmt = ""; - full_msginfo = procmsg_msginfo_get_full_info(msginfo); if (!full_msginfo) full_msginfo = procmsg_msginfo_copy(msginfo); -- 1.6.3.3 From a586c8493f18a5d5721f6960f47a6b555413ef51 Mon Sep 17 00:00:00 2001 From: Fabian Keil Date: Sun, 5 Jul 2009 12:36:08 +0200 Subject: [PATCH 15/68] In the switch() block in update_signature_noticeview(), make it more obvious that that SIGNATURE_CHECK_FAILED and SIGNATURE_CHECK_TIMEOUT are treated the same. Also let them have their own break statement instead of falling through the default case. --- src/mimeview.c | 4 +--- 1 files changed, 1 insertions(+), 3 deletions(-) diff --git a/src/mimeview.c b/src/mimeview.c index 6c3cb30..fd60e17 100644 --- a/src/mimeview.c +++ b/src/mimeview.c @@ -895,13 +895,11 @@ static void update_signature_noticeview(MimeView *mimeview, MimeInfo *mimeinfo, icon = STOCK_PIXMAP_PRIVACY_FAILED; break; case SIGNATURE_CHECK_FAILED: - button_text = _("Check again"); - func = check_signature_cb; - icon = STOCK_PIXMAP_PRIVACY_UNKNOWN; case SIGNATURE_CHECK_TIMEOUT: button_text = _("Check again"); func = check_signature_cb; icon = STOCK_PIXMAP_PRIVACY_UNKNOWN; + break; default: break; } -- 1.6.3.3 From 6b70b4d8973a3f8a4dc154cce0540390845f609d Mon Sep 17 00:00:00 2001 From: Fabian Keil Date: Sun, 28 Jun 2009 17:41:24 +0200 Subject: [PATCH 16/68] Remove write-only variable done in procmime_parse_multipart(), assume it was supposed to end the loop and break out of it instead of setting done. --- src/procmime.c | 5 +---- 1 files changed, 1 insertions(+), 4 deletions(-) diff --git a/src/procmime.c b/src/procmime.c index 8307a9f..53f0e52 100644 --- a/src/procmime.c +++ b/src/procmime.c @@ -1553,7 +1553,6 @@ static void procmime_parse_multipart(MimeInfo *mimeinfo, gboolean short_scan) gchar buf[BUFFSIZE]; FILE *fp; int result = 0; - gboolean done = FALSE; gboolean start_found = FALSE; gboolean end_found = FALSE; @@ -1589,10 +1588,8 @@ static void procmime_parse_multipart(MimeInfo *mimeinfo, gboolean short_scan) hentry[6].body, hentry[7].body, mimeinfo->data.filename, lastoffset, len, short_scan); - if (result == 1 && short_scan) { - done = TRUE; + if (result == 1 && short_scan) break; - } } if (buf[2 + boundary_len] == '-' && -- 1.6.3.3 From 390fd855c39f6ad71db42b16669ba9a183040c45 Mon Sep 17 00:00:00 2001 From: Fabian Keil Date: Sun, 5 Jul 2009 12:36:05 +0200 Subject: [PATCH 17/68] bp and ep are pointers so use NULL instead of 0. --- src/compose.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/compose.c b/src/compose.c index 30a32a5..19704ca 100644 --- a/src/compose.c +++ b/src/compose.c @@ -4265,7 +4265,7 @@ colorize: } } - bp = ep = 0; + bp = ep = NULL; if (scanpos) { /* check if URI can be parsed */ if (parser[last_index].parse(walk, scanpos, (const gchar **)&bp, -- 1.6.3.3 From 3c0906f8806373c679be58ed1306688cd7445914 Mon Sep 17 00:00:00 2001 From: Fabian Keil Date: Sun, 5 Jul 2009 12:36:00 +0200 Subject: [PATCH 18/68] Remove unecessary increment. --- src/common/utils.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/common/utils.c b/src/common/utils.c index 276bbb1..8902cbb 100644 --- a/src/common/utils.c +++ b/src/common/utils.c @@ -4000,7 +4000,7 @@ void get_hex_str(gchar *out, guchar ch) INT_TO_HEX(hex, ch >> 4); *out++ = hex; INT_TO_HEX(hex, ch & 0x0f); - *out++ = hex; + *out = hex; } #undef REF_DEBUG -- 1.6.3.3 From 6e414cb6ea49144a5dcc56312234f6785801f37a Mon Sep 17 00:00:00 2001 From: Fabian Keil Date: Sun, 5 Jul 2009 12:36:00 +0200 Subject: [PATCH 19/68] Remove pointless increment. --- src/common/utils.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/common/utils.c b/src/common/utils.c index 8902cbb..80ba256 100644 --- a/src/common/utils.c +++ b/src/common/utils.c @@ -5227,7 +5227,7 @@ size_t fast_strftime(gchar *buf, gint buflen, const gchar *format, struct tm *lt *curpos++ = *format++; } } - *curpos++ = '\0'; + *curpos = '\0'; return total_done; } -- 1.6.3.3 From 49ba79cf36c7a3b45cc4c7a0b2cc5d32c5322a46 Mon Sep 17 00:00:00 2001 From: Fabian Keil Date: Sun, 5 Jul 2009 12:36:00 +0200 Subject: [PATCH 20/68] Incrementing rowcount has no effect here. --- src/compose.c | 2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/src/compose.c b/src/compose.c index 19704ca..b1552c0 100644 --- a/src/compose.c +++ b/src/compose.c @@ -6660,8 +6660,6 @@ static GtkWidget *compose_create_others(Compose *compose) G_CALLBACK(compose_savemsg_select_cb), compose); - rowcount++; - return table; } -- 1.6.3.3 From 7596727315f287d0cdfb25ec5aaeb55477557e83 Mon Sep 17 00:00:00 2001 From: Fabian Keil Date: Sun, 5 Jul 2009 12:36:01 +0200 Subject: [PATCH 21/68] Initializing p once is enough. --- src/common/utils.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/common/utils.c b/src/common/utils.c index 80ba256..391e02e 100644 --- a/src/common/utils.c +++ b/src/common/utils.c @@ -2856,7 +2856,7 @@ gint canonicalize_file_replace(const gchar *file) gchar *normalize_newlines(const gchar *str) { - const gchar *p = str; + const gchar *p; gchar *out, *outp; out = outp = g_malloc(strlen(str) + 1); -- 1.6.3.3 From e6865edf51c7025786f180cf1946e708753d642f Mon Sep 17 00:00:00 2001 From: Fabian Keil Date: Sun, 5 Jul 2009 12:36:01 +0200 Subject: [PATCH 22/68] prev_autowrap is already initialized through the macros. --- src/compose.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/compose.c b/src/compose.c index b1552c0..39299fe 100644 --- a/src/compose.c +++ b/src/compose.c @@ -2227,7 +2227,7 @@ Compose *compose_reedit(MsgInfo *msginfo, gboolean batch) } if (fp != NULL) { - gboolean prev_autowrap = compose->autowrap; + gboolean prev_autowrap; GtkTextBuffer *buffer = textbuf; BLOCK_WRAP(); while (fgets(buf, sizeof(buf), fp) != NULL) { -- 1.6.3.3 From cb8b115e9017a682f73cf360d54a5d56414b2fbe Mon Sep 17 00:00:00 2001 From: Fabian Keil Date: Sun, 5 Jul 2009 12:36:01 +0200 Subject: [PATCH 23/68] buffer will be initialized by BLOC_WRAP(). --- src/compose.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/compose.c b/src/compose.c index 39299fe..3fc3387 100644 --- a/src/compose.c +++ b/src/compose.c @@ -2228,7 +2228,7 @@ Compose *compose_reedit(MsgInfo *msginfo, gboolean batch) if (fp != NULL) { gboolean prev_autowrap; - GtkTextBuffer *buffer = textbuf; + GtkTextBuffer *buffer; BLOCK_WRAP(); while (fgets(buf, sizeof(buf), fp) != NULL) { strcrchomp(buf); -- 1.6.3.3 From 0556fe949d82386ec69fc66b0a8cb7a9328d6666 Mon Sep 17 00:00:00 2001 From: Fabian Keil Date: Sun, 5 Jul 2009 12:36:01 +0200 Subject: [PATCH 24/68] Initializing p once is enough. --- src/procheader.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/procheader.c b/src/procheader.c index 5b9b545..a727289 100644 --- a/src/procheader.c +++ b/src/procheader.c @@ -274,7 +274,7 @@ gboolean procheader_headername_equal(char * hdr1, char * hdr2) Header * procheader_parse_header(gchar * buf) { - gchar *p = buf; + gchar *p; Header * header; if ((*buf == ':') || (*buf == ' ')) -- 1.6.3.3 From 996845cd0deb9efc6ed926a0200373f2d83a0673 Mon Sep 17 00:00:00 2001 From: Fabian Keil Date: Sun, 5 Jul 2009 12:36:02 +0200 Subject: [PATCH 25/68] Fix white space. --- src/procheader.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/procheader.c b/src/procheader.c index a727289..5479bb4 100644 --- a/src/procheader.c +++ b/src/procheader.c @@ -275,7 +275,7 @@ gboolean procheader_headername_equal(char * hdr1, char * hdr2) Header * procheader_parse_header(gchar * buf) { gchar *p; - Header * header; + Header *header; if ((*buf == ':') || (*buf == ' ')) return NULL; -- 1.6.3.3 From a28d2d0153c72be36b7127821b712bae2d1f6fdf Mon Sep 17 00:00:00 2001 From: Fabian Keil Date: Sun, 5 Jul 2009 12:36:02 +0200 Subject: [PATCH 26/68] Initializing cur once is enough. --- src/procmsg.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/procmsg.c b/src/procmsg.c index e3021b0..cb75982 100644 --- a/src/procmsg.c +++ b/src/procmsg.c @@ -821,7 +821,7 @@ static gboolean procmsg_is_last_for_account(FolderItem *queue, MsgInfo *msginfo, { gchar *file = folder_item_fetch_msg(queue, msginfo->msgnum); PrefsAccount *ac = procmsg_get_account_from_file(file); - GSList *cur = elem; + GSList *cur; g_free(file); for (cur = elem; cur; cur = cur->next) { MsgInfo *cur_msginfo = (MsgInfo *)cur->data; -- 1.6.3.3 From 0b74ded861455be0e0dcfc3be21bd839f4e7921e Mon Sep 17 00:00:00 2001 From: Fabian Keil Date: Sun, 5 Jul 2009 12:36:02 +0200 Subject: [PATCH 27/68] Set start_node to item->node directly. There's no need to involve node. --- src/folder.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/folder.c b/src/folder.c index 15c53c5..4a61ce2 100644 --- a/src/folder.c +++ b/src/folder.c @@ -404,7 +404,7 @@ void folder_item_remove(FolderItem *item) cm_return_if_fail(item->folder != NULL); cm_return_if_fail(item->folder->node != NULL); - start_node = node = item->node; + start_node = item->node; node = item->folder->node; -- 1.6.3.3 From d16876b2aebb94716adac70e59bd6fc5b9bd2243 Mon Sep 17 00:00:00 2001 From: Fabian Keil Date: Sun, 5 Jul 2009 12:36:02 +0200 Subject: [PATCH 28/68] Remove interim variable tags. Maybe tmp should be renamed to tags. --- src/prefs_filtering_action.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/prefs_filtering_action.c b/src/prefs_filtering_action.c index abae26f..f419f48 100644 --- a/src/prefs_filtering_action.c +++ b/src/prefs_filtering_action.c @@ -360,7 +360,7 @@ static void prefs_filtering_action_create(void) static GdkGeometry geometry; GList * accounts; - GSList *tmp, *tags; + GSList *tmp; GtkSizeGroup *size_group = gtk_size_group_new(GTK_SIZE_GROUP_HORIZONTAL); GtkSizeGroup *size_action = gtk_size_group_new(GTK_SIZE_GROUP_HORIZONTAL); @@ -513,7 +513,7 @@ static void prefs_filtering_action_create(void) tags_combo = gtk_combo_box_new_text (); gtk_size_group_add_widget(size_action, tags_combo); - for (tmp = tags = tags_get_list() ; tmp != NULL; + for (tmp = tags_get_list() ; tmp != NULL; tmp = tmp->next) { gchar *name = g_strdup(tags_get_tag(GPOINTER_TO_INT(tmp->data))); -- 1.6.3.3 From 7b5b72e15eb5252073e452d459a3f829d24dd7e0 Mon Sep 17 00:00:00 2001 From: Fabian Keil Date: Sun, 5 Jul 2009 12:36:03 +0200 Subject: [PATCH 29/68] Fix dead stores. The inner loops already take care of setting n to 0. --- src/textview.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/textview.c b/src/textview.c index 5d326f1..a791f35 100644 --- a/src/textview.c +++ b/src/textview.c @@ -1249,7 +1249,7 @@ static void textview_make_clickable_parts(TextView *textview, gtk_text_buffer_get_end_iter(buffer, &iter); /* parse for clickable parts, and build a list of begin and end positions */ - for (walk = mybuf, n = 0;;) { + for (walk = mybuf;;) { gint last_index = PARSE_ELEMS; gchar *scanpos = NULL; @@ -1369,7 +1369,7 @@ static void textview_make_clickable_parts_later(TextView *textview, offset = gtk_text_iter_get_offset(&start_iter); /* parse for clickable parts, and build a list of begin and end positions */ - for (walk = mybuf, n = 0;;) { + for (walk = mybuf;;) { gint last_index = PARSE_ELEMS; gchar *scanpos = NULL; -- 1.6.3.3 From d6371731616356cd9ef93254b9070f71422ec465 Mon Sep 17 00:00:00 2001 From: Fabian Keil Date: Sun, 5 Jul 2009 12:36:03 +0200 Subject: [PATCH 30/68] str will never be read from srcp. --- src/common/utils.c | 10 +++++----- 1 files changed, 5 insertions(+), 5 deletions(-) diff --git a/src/common/utils.c b/src/common/utils.c index 391e02e..30d39c2 100644 --- a/src/common/utils.c +++ b/src/common/utils.c @@ -704,7 +704,7 @@ void eliminate_parenthesis(gchar *str, gchar op, gchar cl) register gchar *srcp, *destp; gint in_brace; - srcp = destp = str; + destp = str; while ((destp = strchr(destp, op))) { in_brace = 1; @@ -728,7 +728,7 @@ void extract_parenthesis(gchar *str, gchar op, gchar cl) register gchar *srcp, *destp; gint in_brace; - srcp = destp = str; + destp = str; while ((srcp = strchr(destp, op))) { if (destp > str) @@ -757,7 +757,7 @@ static void extract_parenthesis_with_skip_quote(gchar *str, gchar quote_chr, gint in_brace; gboolean in_quote = FALSE; - srcp = destp = str; + destp = str; while ((srcp = strchr_with_skip_quote(destp, quote_chr, op))) { if (destp > str) @@ -803,7 +803,7 @@ void eliminate_address_comment(gchar *str) register gchar *srcp, *destp; gint in_brace; - srcp = destp = str; + destp = str; while ((destp = strchr(destp, '"'))) { if ((srcp = strchr(destp + 1, '"'))) { @@ -820,7 +820,7 @@ void eliminate_address_comment(gchar *str) } } - srcp = destp = str; + destp = str; while ((destp = strchr_with_skip_quote(destp, '"', '('))) { in_brace = 1; -- 1.6.3.3 From efcc00230a7bb5c33aa34eed6b42dcea72cf3663 Mon Sep 17 00:00:00 2001 From: Fabian Keil Date: Sun, 5 Jul 2009 12:36:03 +0200 Subject: [PATCH 31/68] Remove write-only variable gtktext. --- src/gtk/gtkaspell.c | 12 ------------ 1 files changed, 0 insertions(+), 12 deletions(-) diff --git a/src/gtk/gtkaspell.c b/src/gtk/gtkaspell.c index 7c90c07..8c1e869 100644 --- a/src/gtk/gtkaspell.c +++ b/src/gtk/gtkaspell.c @@ -911,12 +911,9 @@ static gboolean check_at(GtkAspell *gtkaspell, gint from_pos) { gint start, end; char buf[GTKASPELLWORDSIZE]; - GtkTextView *gtktext; cm_return_val_if_fail(from_pos >= 0, FALSE); - gtktext = gtkaspell->gtktext; - if (!get_word_from_pos(gtkaspell, from_pos, buf, sizeof(buf), &start, &end)) return FALSE; @@ -1264,10 +1261,7 @@ static void replace_real_word_cb(gpointer data, const gchar *newword) /* Accept this word for this session */ static void add_word_to_session_cb(GtkWidget *w, gpointer data) { - GtkTextView *gtktext; GtkAspell *gtkaspell = (GtkAspell *) data; - gtktext = gtkaspell->gtktext; - enchant_dict_add_to_session(gtkaspell->gtkaspeller->speller, gtkaspell->theword, strlen(gtkaspell->theword)); @@ -1731,12 +1725,10 @@ static GSList *make_sug_menu(GtkAspell *gtkaspell) { GtkWidget *item; char *caption; - GtkTextView *gtktext; GtkAccelGroup *accel; GList *l = gtkaspell->suggestions_list; gchar *utf8buf; GSList *list = NULL; - gtktext = gtkaspell->gtktext; if (l == NULL) return NULL; @@ -2189,10 +2181,6 @@ static void switch_to_alternate_cb(GtkWidget *w, static void set_point_continue(GtkAspell *gtkaspell) { - GtkTextView *gtktext; - - gtktext = gtkaspell->gtktext; - gtkaspell->ctx.set_position(gtkaspell->ctx.data, gtkaspell->orig_pos); if (gtkaspell->continue_check) -- 1.6.3.3 From 98f7c73614e554f887673674bca30f9249be13ba Mon Sep 17 00:00:00 2001 From: Fabian Keil Date: Sun, 5 Jul 2009 12:36:03 +0200 Subject: [PATCH 32/68] Don't intialize tmp twice. --- src/gtk/gtkaspell.c | 1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/src/gtk/gtkaspell.c b/src/gtk/gtkaspell.c index 8c1e869..3cd9a0c 100644 --- a/src/gtk/gtkaspell.c +++ b/src/gtk/gtkaspell.c @@ -1952,7 +1952,6 @@ static GSList *populate_submenu(GtkAspell *gtkaspell) int count = 0; Dictionary *dict; GSList *tmp; - tmp = gtkaspellcheckers->dictionary_list; for (tmp = gtkaspellcheckers->dictionary_list; tmp != NULL; tmp = g_slist_next(tmp)) { -- 1.6.3.3 From 0cee4680bf882e7720b91335dd5a07c6cf7dc34c Mon Sep 17 00:00:00 2001 From: Fabian Keil Date: Sun, 5 Jul 2009 12:36:04 +0200 Subject: [PATCH 33/68] This hbox doesn't seem to be used. --- src/gtk/gtkaspell.c | 2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/src/gtk/gtkaspell.c b/src/gtk/gtkaspell.c index 3cd9a0c..0c80c72 100644 --- a/src/gtk/gtkaspell.c +++ b/src/gtk/gtkaspell.c @@ -1441,8 +1441,6 @@ static void replace_with_create_dialog_cb(GtkWidget *w, gpointer data) gtk_box_pack_start(GTK_BOX(vbox), label, FALSE, FALSE, 0); gtk_widget_show(label); - hbox = gtk_hbox_new(TRUE, 0); - gtkut_stock_button_set_create(&confirm_area, &cancel_button, GTK_STOCK_CANCEL, &ok_button, GTK_STOCK_OK, -- 1.6.3.3 From 198dd14d1771763aa6c5352dceca1cb18932d620 Mon Sep 17 00:00:00 2001 From: Fabian Keil Date: Sun, 5 Jul 2009 12:36:04 +0200 Subject: [PATCH 34/68] Remove write-only variable wordlen. --- src/gtk/gtkaspell.c | 3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/src/gtk/gtkaspell.c b/src/gtk/gtkaspell.c index 0c80c72..ee15186 100644 --- a/src/gtk/gtkaspell.c +++ b/src/gtk/gtkaspell.c @@ -1181,7 +1181,7 @@ static void replace_word_cb(GtkWidget *w, gpointer data) static void replace_real_word(GtkAspell *gtkaspell, const gchar *newword) { - int oldlen, newlen, wordlen; + int oldlen, newlen; gint origpos; gint pos; GtkTextView *gtktext; @@ -1196,7 +1196,6 @@ static void replace_real_word(GtkAspell *gtkaspell, const gchar *newword) origpos = gtkaspell->orig_pos; pos = origpos; oldlen = gtkaspell->end_pos - gtkaspell->start_pos; - wordlen = strlen(gtkaspell->theword); newlen = strlen(newword); /* FIXME: multybyte characters? */ -- 1.6.3.3 From f7f63bc5e0bd1b4bfc87266c77e0669c930cf616 Mon Sep 17 00:00:00 2001 From: Fabian Keil Date: Sun, 5 Jul 2009 12:36:04 +0200 Subject: [PATCH 35/68] Remove write-only variable end. Mark parameter as unused. --- src/gtk/gtkaspell.c | 8 +++++--- 1 files changed, 5 insertions(+), 3 deletions(-) diff --git a/src/gtk/gtkaspell.c b/src/gtk/gtkaspell.c index ee15186..6ef689e 100644 --- a/src/gtk/gtkaspell.c +++ b/src/gtk/gtkaspell.c @@ -513,15 +513,17 @@ static void entry_delete_cb(GtkTextBuffer *textbuf, GtkAspell *gtkaspell) { int origpos; - gint start, end; - + gint start; + + /* XXX: unused parameter. */ + (void)enditer; + cm_return_if_fail(gtkaspell->gtkaspeller->speller); if (!gtkaspell->check_while_typing) return; start = gtk_text_iter_get_offset(startiter); - end = gtk_text_iter_get_offset(enditer); origpos = get_textview_buffer_offset(gtkaspell->gtktext); if (start) { check_at(gtkaspell, start - 1); -- 1.6.3.3 From cb45cf75c45087e8a1af9819c3f6facd9b971572 Mon Sep 17 00:00:00 2001 From: Fabian Keil Date: Sun, 5 Jul 2009 12:36:04 +0200 Subject: [PATCH 36/68] Remove write-only variable is_group. --- src/addr_compl.c | 9 ++------- 1 files changed, 2 insertions(+), 7 deletions(-) diff --git a/src/addr_compl.c b/src/addr_compl.c index e16d33c..e32ff4c 100644 --- a/src/addr_compl.c +++ b/src/addr_compl.c @@ -246,14 +246,9 @@ static gint add_address(const gchar *name, const gchar *address, const gchar *nick, const gchar *alias, GList *grp_emails) { address_entry *ae; - gboolean is_group = FALSE; - if (!name || !address) { - if (!address && !nick && !alias && grp_emails) { - is_group = TRUE; - } else - return -1; - } + if ((!name || !address) && (nick || alias || !grp_emails)) + return -1; ae = g_new0(address_entry, 1); -- 1.6.3.3 From 7ec1eaa0d6db87fc897b15becdbac08c283bc261 Mon Sep 17 00:00:00 2001 From: Fabian Keil Date: Sun, 5 Jul 2009 12:36:04 +0200 Subject: [PATCH 37/68] Fix dead store. --- src/addrharvest.c | 1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/src/addrharvest.c b/src/addrharvest.c index 8cb51ef..df1c0c3 100644 --- a/src/addrharvest.c +++ b/src/addrharvest.c @@ -528,7 +528,6 @@ static void addrharvest_parse_address( name = g_strdup(""); } else { - name = buffer; name = conv_unmime_header(buffer, NULL); } -- 1.6.3.3 From 809ebc12a73f05e4c7160133024fef23de162023 Mon Sep 17 00:00:00 2001 From: Fabian Keil Date: Sun, 5 Jul 2009 12:36:05 +0200 Subject: [PATCH 38/68] Remove write-only variable prev_level. --- src/addrindex.c | 2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/src/addrindex.c b/src/addrindex.c index a6e0de5..8a9b91d 100644 --- a/src/addrindex.c +++ b/src/addrindex.c @@ -1569,7 +1569,6 @@ static int addrindex_write_ldap( FILE *fp, AddressDataSource *ds, gint lvl ) { * \param file Address index file. */ static void addrindex_read_index( AddressIndex *addrIndex, XMLFile *file ) { - guint prev_level; XMLTag *xtag; AddressInterface *iface = NULL, *dsIFace = NULL; AddressDataSource *ds; @@ -1577,7 +1576,6 @@ static void addrindex_read_index( AddressIndex *addrIndex, XMLFile *file ) { addrIndex->loadedFlag = FALSE; for (;;) { - prev_level = file->level; rc = xml_parse_next_tag( file ); if( file->level == 0 ) return; -- 1.6.3.3 From 5d7b84b1e9b3980edfdf20793e6778860f089330 Mon Sep 17 00:00:00 2001 From: Fabian Keil Date: Sun, 5 Jul 2009 12:36:06 +0200 Subject: [PATCH 39/68] Remove write-only variable style. --- src/compose.c | 3 --- 1 files changed, 0 insertions(+), 3 deletions(-) diff --git a/src/compose.c b/src/compose.c index 3fc3387..615d629 100644 --- a/src/compose.c +++ b/src/compose.c @@ -854,10 +854,7 @@ static void compose_create_tags(GtkTextView *text, Compose *compose) for (i = 0; i < 8; i++) { if (success[i] == FALSE) { - GtkStyle *style; - g_warning("Compose: color allocation failed.\n"); - style = gtk_widget_get_style(GTK_WIDGET(text)); quote_color1 = quote_color2 = quote_color3 = quote_bgcolor1 = quote_bgcolor2 = quote_bgcolor3 = signature_color = uri_color = black; -- 1.6.3.3 From 9c844cba96a1bc51979fc9ff99701d650ad00b3f Mon Sep 17 00:00:00 2001 From: Fabian Keil Date: Sun, 5 Jul 2009 12:36:06 +0200 Subject: [PATCH 40/68] Remove write-only variable folder. --- src/folder.c | 4 ---- 1 files changed, 0 insertions(+), 4 deletions(-) diff --git a/src/folder.c b/src/folder.c index 4a61ce2..3360fe4 100644 --- a/src/folder.c +++ b/src/folder.c @@ -2652,13 +2652,11 @@ void folder_item_write_cache(FolderItem *item) MsgInfo *folder_item_get_msginfo(FolderItem *item, gint num) { - Folder *folder; MsgInfo *msginfo = NULL; cm_return_val_if_fail(item != NULL, NULL); if (item->no_select) return NULL; - folder = item->folder; if (!item->cache) folder_item_read_cache(item); @@ -2676,7 +2674,6 @@ MsgInfo *folder_item_get_msginfo(FolderItem *item, gint num) MsgInfo *folder_item_get_msginfo_by_msgid(FolderItem *item, const gchar *msgid) { - Folder *folder; MsgInfo *msginfo; cm_return_val_if_fail(item != NULL, NULL); @@ -2684,7 +2681,6 @@ MsgInfo *folder_item_get_msginfo_by_msgid(FolderItem *item, const gchar *msgid) if (item->no_select) return FALSE; - folder = item->folder; if (!item->cache) folder_item_read_cache(item); -- 1.6.3.3 From fc048e0b682b54c9a2147801d98c3322fa4d0169 Mon Sep 17 00:00:00 2001 From: Fabian Keil Date: Sun, 5 Jul 2009 12:36:06 +0200 Subject: [PATCH 41/68] Fix dead store. --- src/folder.c | 2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/src/folder.c b/src/folder.c index 3360fe4..6863ea5 100644 --- a/src/folder.c +++ b/src/folder.c @@ -3212,8 +3212,6 @@ gint folder_item_move_to(FolderItem *src, FolderItem *dest, FolderItem **new_ite tmp = folder_item_parent(tmp); } - tmp = folder_item_parent(src); - src_identifier = folder_item_get_identifier(src); dst_identifier = folder_item_get_identifier(dest); -- 1.6.3.3 From 436182caed4e9d21d11e55fbd78e49f02b13580a Mon Sep 17 00:00:00 2001 From: Fabian Keil Date: Sun, 5 Jul 2009 12:36:06 +0200 Subject: [PATCH 42/68] Remove write-only variable finished --- src/imap.c | 2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/src/imap.c b/src/imap.c index 9b90557..61b9222 100644 --- a/src/imap.c +++ b/src/imap.c @@ -3073,9 +3073,7 @@ static GSList *imap_get_uncached_messages(IMAPSession *session, GSList *result = NULL; GSList * cur; uncached_data *data = g_new0(uncached_data, 1); - int finished; - finished = 0; cur = numlist; data->total = g_slist_length(numlist); data->ok = MAILIMAP_NO_ERROR; -- 1.6.3.3 From d6d0856e7ac722cb8e2c36eff6d91c679c8f687d Mon Sep 17 00:00:00 2001 From: Fabian Keil Date: Sun, 5 Jul 2009 12:36:06 +0200 Subject: [PATCH 43/68] Remove write-only variable single. --- src/imap.c | 3 --- 1 files changed, 0 insertions(+), 3 deletions(-) diff --git a/src/imap.c b/src/imap.c index 61b9222..9e8c817 100644 --- a/src/imap.c +++ b/src/imap.c @@ -1737,7 +1737,6 @@ static gint imap_do_copy_msgs(Folder *folder, FolderItem *dest, gint ok = MAILIMAP_NO_ERROR; GRelation *uid_mapping; gint last_num = 0; - gboolean single = FALSE; g_return_val_if_fail(folder != NULL, -1); g_return_val_if_fail(dest != NULL, -1); @@ -1751,8 +1750,6 @@ static gint imap_do_copy_msgs(Folder *folder, FolderItem *dest, } msginfo = (MsgInfo *)msglist->data; - if (msglist->next == NULL) - single = TRUE; src = msginfo->folder; if (src == dest) { g_warning("the src folder is identical to the dest.\n"); -- 1.6.3.3 From a595f67b810c994893aa0a1c34816ea8c7657e21 Mon Sep 17 00:00:00 2001 From: Fabian Keil Date: Sun, 5 Jul 2009 12:36:06 +0200 Subject: [PATCH 44/68] Remove write-only variable lastuid_old. --- src/imap.c | 4 +--- 1 files changed, 1 insertions(+), 3 deletions(-) diff --git a/src/imap.c b/src/imap.c index 9e8c817..b66352a 100644 --- a/src/imap.c +++ b/src/imap.c @@ -3956,7 +3956,7 @@ static gint get_list_of_uids(IMAPSession *session, Folder *folder, IMAPFolderIte GSList *uidlist, *elem; int r = -1; clist * lep_uidlist; - gint ok, nummsgs = 0, lastuid_old; + gint ok, nummsgs = 0; if (session == NULL) { return -1; @@ -4006,8 +4006,6 @@ static gint get_list_of_uids(IMAPSession *session, Folder *folder, IMAPFolderIte return -1; } - lastuid_old = item->lastuid; - for (elem = uidlist; elem != NULL; elem = g_slist_next(elem)) { guint msgnum; -- 1.6.3.3 From 41f4dce7e8afce5a9079127ed9c9531567b89693 Mon Sep 17 00:00:00 2001 From: Fabian Keil Date: Sun, 5 Jul 2009 12:36:07 +0200 Subject: [PATCH 45/68] Remove write-only variable selected_folder. --- src/imap.c | 4 ---- 1 files changed, 0 insertions(+), 4 deletions(-) diff --git a/src/imap.c b/src/imap.c index b66352a..50329a6 100644 --- a/src/imap.c +++ b/src/imap.c @@ -4030,7 +4030,6 @@ gint imap_get_num_list(Folder *folder, FolderItem *_item, GSList **msgnum_list, gint nummsgs; GSList *uidlist = NULL; gchar *dir; - gboolean selected_folder; gint known_list_len = 0; debug_print("get_num_list\n"); @@ -4074,9 +4073,6 @@ gint imap_get_num_list(Folder *folder, FolderItem *_item, GSList **msgnum_list, statusbar_print_all(_("Scanning folder %s ..."), FOLDER_ITEM(item)->folder->name); - selected_folder = (session->mbox != NULL) && - (!strcmp(session->mbox, item->item.path)); - if (item->should_trash_cache) { *old_uids_valid = FALSE; debug_print("get_num_list: trashing num list\n"); -- 1.6.3.3 From 5f7c7e1c48dea6011fdd17bdddb75d19b891b64e Mon Sep 17 00:00:00 2001 From: Fabian Keil Date: Sun, 5 Jul 2009 12:36:07 +0200 Subject: [PATCH 46/68] Remove dead assignment. --- src/mainwindow.c | 1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/src/mainwindow.c b/src/mainwindow.c index ff0be72..038a0b9 100644 --- a/src/mainwindow.c +++ b/src/mainwindow.c @@ -3283,7 +3283,6 @@ void main_window_set_menu_sensitive(MainWindow *mainwin) messageview_is_visible(mainwin->messageview)); summaryview = mainwin->summaryview; - menu_path = "Menu/View/Sort/DontSort"; switch (summaryview->sort_key) { case SORT_BY_NUMBER: -- 1.6.3.3 From 2e7a0b5aa7b77bf1f245124208b4979fc91cb1af Mon Sep 17 00:00:00 2001 From: Fabian Keil Date: Sun, 5 Jul 2009 12:36:07 +0200 Subject: [PATCH 47/68] Remove dead assignment. --- src/imap.c | 1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/src/imap.c b/src/imap.c index 50329a6..e64e501 100644 --- a/src/imap.c +++ b/src/imap.c @@ -5689,7 +5689,6 @@ char* imap_modified_utf7_to_utf8(const char *mbox, gboolean change_spaces) const char *src; char *dst, *res = malloc(2*strlen(mbox)+1); - bitbuf = 0; dst = res; src = mbox; if(!dst) return NULL; -- 1.6.3.3 From 4f60c0f29957824ac8a0e2ebfe3d6d09b7b8bcb6 Mon Sep 17 00:00:00 2001 From: Fabian Keil Date: Sun, 5 Jul 2009 12:36:07 +0200 Subject: [PATCH 48/68] Remove dead assignment. --- src/ldif.c | 1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/src/ldif.c b/src/ldif.c index aa7c73c..d8f3b74 100644 --- a/src/ldif.c +++ b/src/ldif.c @@ -721,7 +721,6 @@ static void ldif_read_file( LdifFile *ldifFile, AddressCache *cache ) { mgu_free_list( listValue ); lastTag = NULL; listValue = NULL; - last64 = FALSE; } lastTag = g_strdup( tagName ); -- 1.6.3.3 From ad6acf8be680e6897db350735a47d8b8b9a0cdbc Mon Sep 17 00:00:00 2001 From: Fabian Keil Date: Sun, 5 Jul 2009 12:36:07 +0200 Subject: [PATCH 49/68] Remove dead assignment. --- src/imap.c | 1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/src/imap.c b/src/imap.c index e64e501..727ce2b 100644 --- a/src/imap.c +++ b/src/imap.c @@ -5822,7 +5822,6 @@ char* imap_utf8_to_modified_utf7(const char *src, gboolean change_spaces) /* Encode US-ASCII characters as themselves */ if (c < 0x80) { ucs4 = c; - utf8total = 1; } else if (utf8total) { /* save UTF8 bits into UCS4 */ ucs4 = (ucs4 << 6) | (c & 0x3FUL); -- 1.6.3.3 From 925a490f6683951c3bebe125e941fa6c36f7dc30 Mon Sep 17 00:00:00 2001 From: Fabian Keil Date: Sun, 5 Jul 2009 12:36:07 +0200 Subject: [PATCH 50/68] Remove dead assignment in main_window_toggle_message_view(). --- src/mainwindow.c | 1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/src/mainwindow.c b/src/mainwindow.c index 038a0b9..3ce57de 100644 --- a/src/mainwindow.c +++ b/src/mainwindow.c @@ -2837,7 +2837,6 @@ void main_window_toggle_message_view(MainWindow *mainwin) } break; case WIDE_LAYOUT: - ppaned = mainwin->hpaned; container = mainwin->vpaned; if (mainwin->messageview->vbox->parent != NULL) { mainwin->messageview->visible = FALSE; -- 1.6.3.3 From e12009f2db467690adf9f134e4ff3394017ccdd5 Mon Sep 17 00:00:00 2001 From: Fabian Keil Date: Sun, 5 Jul 2009 12:36:08 +0200 Subject: [PATCH 51/68] Remove dead assignment in mainwindow_tags_menu_item_activate_item_cb(). --- src/mainwindow.c | 1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/src/mainwindow.c b/src/mainwindow.c index 3ce57de..da16d60 100644 --- a/src/mainwindow.c +++ b/src/mainwindow.c @@ -1009,7 +1009,6 @@ static void mainwindow_tags_menu_item_activate_item_cb(GtkMenuItem *menu_item, for (; tags; tags = tags->next) { gint num_checked = GPOINTER_TO_INT(g_hash_table_lookup(menu_allsel_table, tags->data)); - id = GPOINTER_TO_INT(tags->data); item = g_hash_table_lookup(menu_table, GINT_TO_POINTER(tags->data)); if (item && !item->active) { gtk_check_menu_item_set_active -- 1.6.3.3 From 35c3b5187b517dc99f5d6113985f272dd36e2ee3 Mon Sep 17 00:00:00 2001 From: Fabian Keil Date: Sun, 5 Jul 2009 12:36:08 +0200 Subject: [PATCH 52/68] Remove dead assignments in proc_mbox(). --- src/mbox.c | 4 ---- 1 files changed, 0 insertions(+), 4 deletions(-) diff --git a/src/mbox.c b/src/mbox.c index df32656..7306742 100644 --- a/src/mbox.c +++ b/src/mbox.c @@ -153,15 +153,11 @@ gint proc_mbox(FolderItem *dest, const gchar *mbox, gboolean apply_filter, empty_lines = 0; lines = 0; - more = FALSE; /* process all lines from mboxrc file */ while (fgets(buf, sizeof(buf), mbox_fp) != NULL) { int offset; - /* eof not reached, expect more lines */ - more = TRUE; - /* eat empty lines */ if (buf[0] == '\n' || buf[0] == '\r') { empty_lines++; -- 1.6.3.3 From f031c5c50fe2b571405668a7fdc826bd0e5146c6 Mon Sep 17 00:00:00 2001 From: Fabian Keil Date: Sun, 5 Jul 2009 12:36:08 +0200 Subject: [PATCH 53/68] Remove write-only variable mainbox_size in icon_list_clear() --- src/mimeview.c | 2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/src/mimeview.c b/src/mimeview.c index fd60e17..12b7423 100644 --- a/src/mimeview.c +++ b/src/mimeview.c @@ -2400,14 +2400,12 @@ static void icon_list_clear (MimeView *mimeview) static void icon_scroll_size_allocate_cb(GtkWidget *widget, GtkAllocation *size, MimeView *mimeview) { - GtkAllocation *mainbox_size; GtkAllocation *vbox_size; GtkAllocation *layout_size; GtkAdjustment *adj; adj = gtk_layout_get_vadjustment(GTK_LAYOUT(mimeview->icon_scroll)); - mainbox_size = &mimeview->icon_mainbox->allocation; vbox_size = &mimeview->icon_vbox->allocation; layout_size = &mimeview->icon_scroll->allocation; -- 1.6.3.3 From 55ccadefdcb406bcf31d146e55220f3017ac7874 Mon Sep 17 00:00:00 2001 From: Fabian Keil Date: Sun, 5 Jul 2009 12:36:08 +0200 Subject: [PATCH 54/68] Remove write-only variable textview in icon_key_pressed() --- src/mimeview.c | 3 --- 1 files changed, 0 insertions(+), 3 deletions(-) diff --git a/src/mimeview.c b/src/mimeview.c index 12b7423..70331b6 100644 --- a/src/mimeview.c +++ b/src/mimeview.c @@ -2103,15 +2103,12 @@ static gint icon_key_pressed(GtkWidget *button, GdkEventKey *event, gint num; MimeInfo *partinfo; SummaryView *summaryview; - TextView *textview; num = GPOINTER_TO_INT(g_object_get_data(G_OBJECT(button), "icon_number")); partinfo = g_object_get_data(G_OBJECT(button), "partinfo"); if (!event) return FALSE; - textview = mimeview->textview; - switch (event->keyval) { case GDK_space: if (mimeview_scroll_page(mimeview, FALSE)) -- 1.6.3.3 From ebb5e560e6141ff8a0322fc7471476d42ff0d856 Mon Sep 17 00:00:00 2001 From: Fabian Keil Date: Sun, 5 Jul 2009 12:36:08 +0200 Subject: [PATCH 55/68] Remove dead assignment in mutt_parse_rcplist(). --- src/mutt.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/mutt.c b/src/mutt.c index 484d567..3efd9ce 100644 --- a/src/mutt.c +++ b/src/mutt.c @@ -214,7 +214,7 @@ static GSList *mutt_parse_rcplist( gchar *rcpList, gint *addrCount ) { pStart = rcpList; while( pStart && *pStart ) { ptr = pStart; - address = name = NULL; + address = NULL; pName = pAddr = NULL; /* Chew up spaces */ while( *ptr ) { -- 1.6.3.3 From 8ac4020a297eee8234a24bd05f0ca2ef6d8ac658 Mon Sep 17 00:00:00 2001 From: Fabian Keil Date: Sun, 5 Jul 2009 12:36:09 +0200 Subject: [PATCH 56/68] Remove write-only variable partial_recv. --- src/partial_download.c | 4 ---- 1 files changed, 0 insertions(+), 4 deletions(-) diff --git a/src/partial_download.c b/src/partial_download.c index 3623027..f33c076 100644 --- a/src/partial_download.c +++ b/src/partial_download.c @@ -71,7 +71,6 @@ int partial_msg_in_uidl_list(MsgInfo *msginfo) gchar uidl[POPBUFSIZE]; time_t recv_time; time_t now; - gint partial_recv; gchar *sanitized_uid = NULL; if (!msginfo->extradata) @@ -111,7 +110,6 @@ int partial_msg_in_uidl_list(MsgInfo *msginfo) gchar tmp[POPBUFSIZE]; strretchomp(buf); recv_time = RECV_TIME_NONE; - partial_recv = POP3_TOTALLY_RECEIVED; if (sscanf(buf, "%s\t%ld\t%s", uidl, (long int *) &recv_time, tmp) < 2) { @@ -385,7 +383,6 @@ gchar *partial_get_filename(const gchar *server, const gchar *login, gchar uidl[POPBUFSIZE]; time_t recv_time; time_t now; - gint partial_recv; gchar *sanitized_uid = g_strdup(login); subst_for_filename(sanitized_uid); @@ -415,7 +412,6 @@ gchar *partial_get_filename(const gchar *server, const gchar *login, gchar tmp[POPBUFSIZE]; strretchomp(buf); recv_time = RECV_TIME_NONE; - partial_recv = POP3_TOTALLY_RECEIVED; if (sscanf(buf, "%s\t%ld\t%s", uidl, (long int *) &recv_time, tmp) < 2) { -- 1.6.3.3 From 486c9e4c7f0e4dd0f059e60f17363a5c4d4d56e9 Mon Sep 17 00:00:00 2001 From: Fabian Keil Date: Sun, 5 Jul 2009 12:40:55 +0200 Subject: [PATCH 57/68] Remove write-only variable start_pos in printing_textview_cb_begin_print(). --- src/printing.c | 2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/src/printing.c b/src/printing.c index 8b28634..bad141f 100644 --- a/src/printing.c +++ b/src/printing.c @@ -875,7 +875,6 @@ static void printing_textview_cb_begin_print(GtkPrintOperation *op, GtkPrintCont PangoFontDescription *desc; int start, ii; PangoLayoutIter *iter; - double start_pos; gint header_end_pos; gint num_header_lines; gint dummy; @@ -914,7 +913,6 @@ static void printing_textview_cb_begin_print(GtkPrintOperation *op, GtkPrintCont page_height = 0; start = 0; ii = 0; - start_pos = 0.; iter = pango_layout_get_iter(print_data->layout); /* find the last character of the header */ -- 1.6.3.3 From f03f479531232d1e9cf844e3f8431837b67eafc3 Mon Sep 17 00:00:00 2001 From: Fabian Keil Date: Sun, 28 Jun 2009 17:32:23 +0200 Subject: [PATCH 58/68] Remove write-only variable button in icon_window_button_press(). --- src/prefs_toolbar.c | 4 +--- 1 files changed, 1 insertions(+), 3 deletions(-) diff --git a/src/prefs_toolbar.c b/src/prefs_toolbar.c index 55ddecc..e4456a9 100644 --- a/src/prefs_toolbar.c +++ b/src/prefs_toolbar.c @@ -1352,11 +1352,9 @@ static gboolean icon_window_button_press(GtkWidget *widget, GdkEventButton *event, ToolbarPage *prefs_toolbar ) { - GtkWidget *event_widget, *button; + GtkWidget *event_widget; gboolean restore = TRUE; - button = prefs_toolbar->icon_button; - /* Test where mouse was clicked */ event_widget = gtk_get_event_widget((GdkEvent *)event); if (event_widget != widget) { -- 1.6.3.3 From 59b95190df67da0a617929df04336bbd2fe3c760 Mon Sep 17 00:00:00 2001 From: Fabian Keil Date: Sun, 28 Jun 2009 17:42:55 +0200 Subject: [PATCH 59/68] Remove write-only variable local in procmsg_send_message_queue_full(). --- src/procmsg.c | 3 --- 1 files changed, 0 insertions(+), 3 deletions(-) diff --git a/src/procmsg.c b/src/procmsg.c index cb75982..b4f26d3 100644 --- a/src/procmsg.c +++ b/src/procmsg.c @@ -1458,8 +1458,6 @@ static gint procmsg_send_message_queue_full(const gchar *file, gboolean keep_ses gboolean save_clear_text = TRUE; gchar *tmp_enc_file = NULL; - int local = 0; - cm_return_val_if_fail(file != NULL, -1); if ((fp = g_fopen(file, "rb")) == NULL) { @@ -1603,7 +1601,6 @@ send_mail: } else if (mailac && mailac->use_mail_command && mailac->mail_command && (* mailac->mail_command)) { mailval = send_message_local(mailac->mail_command, fp); - local = 1; } else { if (!mailac) { mailac = account_find_from_smtp_server(from, smtpserver); -- 1.6.3.3 From 4c5e6172cd31167dd3283c6e8eae137e22733f95 Mon Sep 17 00:00:00 2001 From: Fabian Keil Date: Sun, 28 Jun 2009 17:54:25 +0200 Subject: [PATCH 60/68] Remove adbase and cache in addressbook_perform_search(). --- src/addressbook.c | 5 ----- 1 files changed, 0 insertions(+), 5 deletions(-) diff --git a/src/addressbook.c b/src/addressbook.c index e7360c1..45f1519 100644 --- a/src/addressbook.c +++ b/src/addressbook.c @@ -4599,8 +4599,6 @@ static void addressbook_perform_search( AddressDataSource *ds, gchar *searchTerm, GtkCMCTreeNode *pNode ) { - AddrBookBase *adbase; - AddressCache *cache; ItemFolder *folder; gchar *name; gint queryID; @@ -4620,9 +4618,6 @@ static void addressbook_perform_search( else { return; } - /* Get reference to address cache */ - adbase = ( AddrBookBase * ) ds->rawDataSource; - cache = adbase->addressCache; /* Create a folder for the search results */ name = g_strdup_printf( _queryFolderLabel_, searchTerm ); -- 1.6.3.3 From 3bebeac5caab5ed8821df51611f57dc0189e00cb Mon Sep 17 00:00:00 2001 From: Fabian Keil Date: Sun, 28 Jun 2009 17:59:53 +0200 Subject: [PATCH 61/68] How about we actually use rootFolder in addressbook_set_clist(). --- src/addressbook.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/addressbook.c b/src/addressbook.c index 45f1519..bcc6f41 100644 --- a/src/addressbook.c +++ b/src/addressbook.c @@ -3903,9 +3903,9 @@ static void addressbook_set_clist( AddressObject *obj, gboolean refresh ) { ItemFolder *rootFolder = NULL; rootFolder = addrindex_ds_get_root_folder( ds ); addressbook_folder_load_person( - ctreelist, addrindex_ds_get_root_folder( ds ) ); + ctreelist, rootFolder ); addressbook_folder_load_group( - ctreelist, addrindex_ds_get_root_folder( ds ) ); + ctreelist, rootFolder ); } } else { -- 1.6.3.3 From 5a06da1239c85770a3bf1257a2a61ef1762b04e7 Mon Sep 17 00:00:00 2001 From: Fabian Keil Date: Sun, 28 Jun 2009 18:01:45 +0200 Subject: [PATCH 62/68] How about we actually use ads in addressbook_set_clist(). --- src/addressbook.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/addressbook.c b/src/addressbook.c index bcc6f41..6c7f365 100644 --- a/src/addressbook.c +++ b/src/addressbook.c @@ -3897,7 +3897,7 @@ static void addressbook_set_clist( AddressObject *obj, gboolean refresh ) { if( obj->type == ADDR_DATASOURCE ) { ads = ADAPTER_DSOURCE(obj); - ds = ADAPTER_DSOURCE(obj)->dataSource; + ds = ads->dataSource; if( ds ) { /* Load root folder */ ItemFolder *rootFolder = NULL; -- 1.6.3.3 From 9cb7668af146db4ceb45defa35042d2f37f577f0 Mon Sep 17 00:00:00 2001 From: Fabian Keil Date: Sun, 28 Jun 2009 18:12:41 +0200 Subject: [PATCH 63/68] Remove write-only variable row in addressbook_folder_refresh_one_person() --- src/addressbook.c | 2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/src/addressbook.c b/src/addressbook.c index 6c7f365..4f0d3da 100644 --- a/src/addressbook.c +++ b/src/addressbook.c @@ -3730,11 +3730,9 @@ static void addressbook_folder_refresh_one_person( GtkCMCTree *clist, ItemPerson static void addressbook_folder_remove_one_person( GtkCMCTree *clist, ItemPerson *person ) { GtkCMCTreeNode *node; - gint row; if( person == NULL ) return; node = gtk_cmctree_find_by_row_data( clist, NULL, person ); - row = gtk_cmclist_find_row_from_data( GTK_CMCLIST(clist), person ); if( node ) { addressbook_folder_remove_node( clist, node ); } -- 1.6.3.3 From 404e7ce1b9e5fced582e89425cb204849daee696 Mon Sep 17 00:00:00 2001 From: Fabian Keil Date: Sun, 28 Jun 2009 18:29:49 +0200 Subject: [PATCH 64/68] Remove write-only variable i in imap_fetch_result_to_envelop_list() --- src/etpan/imap-thread.c | 2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/src/etpan/imap-thread.c b/src/etpan/imap-thread.c index ab21252..7d9b249 100644 --- a/src/etpan/imap-thread.c +++ b/src/etpan/imap-thread.c @@ -2677,10 +2677,8 @@ imap_fetch_result_to_envelop_list(clist * fetch_result, carray ** p_env_list) { clistiter * cur; - unsigned int i; carray * env_list; - i = 0; env_list = carray_new(16); if (fetch_result) { -- 1.6.3.3 From 1a901f6049a516f9dee64900e2cfb932e575ceaf Mon Sep 17 00:00:00 2001 From: Fabian Keil Date: Sun, 28 Jun 2009 18:37:38 +0200 Subject: [PATCH 65/68] Remove write-only variable textview in gboolean summary_key_pressed() --- src/summaryview.c | 2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/src/summaryview.c b/src/summaryview.c index 41ea23a..16bf599 100644 --- a/src/summaryview.c +++ b/src/summaryview.c @@ -6542,7 +6542,6 @@ static gboolean summary_key_pressed(GtkWidget *widget, GdkEventKey *event, GtkCMCTree *ctree = GTK_CMCTREE(widget); GtkCMCTreeNode *node; MessageView *messageview; - TextView *textview; GtkAdjustment *adj; gboolean mod_pressed; @@ -6553,7 +6552,6 @@ static gboolean summary_key_pressed(GtkWidget *widget, GdkEventKey *event, return FALSE; messageview = summaryview->messageview; - textview = messageview->mimeview->textview; mod_pressed = ((event->state & (GDK_SHIFT_MASK|GDK_MOD1_MASK)) != 0); -- 1.6.3.3 From d2e39ce59582ebf425fda972f998a75cf55292f3 Mon Sep 17 00:00:00 2001 From: Fabian Keil Date: Sun, 28 Jun 2009 18:41:07 +0200 Subject: [PATCH 66/68] Remove write-only variable id in summary_tags_menu_item_activate_item_cb() --- src/summaryview.c | 2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/src/summaryview.c b/src/summaryview.c index 16bf599..4ec9705 100644 --- a/src/summaryview.c +++ b/src/summaryview.c @@ -5934,7 +5934,6 @@ static void summary_tags_menu_item_activate_item_cb(GtkMenuItem *menu_item, for (; sel != NULL; sel = sel->next) { MsgInfo *msginfo; GSList *tags = NULL; - gint id; GtkCheckMenuItem *item; msginfo = gtk_cmctree_node_get_row_data (GTK_CMCTREE(summaryview->ctree), @@ -5947,7 +5946,6 @@ static void summary_tags_menu_item_activate_item_cb(GtkMenuItem *menu_item, for (; tags; tags = tags->next) { gint num_checked = GPOINTER_TO_INT(g_hash_table_lookup(menu_allsel_table, tags->data)); - id = GPOINTER_TO_INT(tags->data); item = g_hash_table_lookup(menu_table, GINT_TO_POINTER(tags->data)); if (item && !item->active) { gtk_check_menu_item_set_active -- 1.6.3.3 From 0c6ef2cd42a70565757fba2ce484929bd00efb2d Mon Sep 17 00:00:00 2001 From: Fabian Keil Date: Sun, 28 Jun 2009 18:44:44 +0200 Subject: [PATCH 67/68] Remove write-only variable changed in summary_lock_row() --- src/summaryview.c | 3 --- 1 files changed, 0 insertions(+), 3 deletions(-) diff --git a/src/summaryview.c b/src/summaryview.c index 4ec9705..e397936 100644 --- a/src/summaryview.c +++ b/src/summaryview.c @@ -3801,7 +3801,6 @@ static void summary_mark_row(SummaryView *summaryview, GtkCMCTreeNode *row) static void summary_lock_row(SummaryView *summaryview, GtkCMCTreeNode *row) { - gboolean changed = FALSE; GtkCMCTree *ctree = GTK_CMCTREE(summaryview->ctree); MsgInfo *msginfo; @@ -3811,11 +3810,9 @@ static void summary_lock_row(SummaryView *summaryview, GtkCMCTreeNode *row) summaryview->deleted--; if (MSG_IS_MOVE(msginfo->flags)) { summaryview->moved--; - changed = TRUE; } if (MSG_IS_COPY(msginfo->flags)) { summaryview->copied--; - changed = TRUE; } procmsg_msginfo_set_to_folder(msginfo, NULL); summary_msginfo_change_flags(msginfo, MSG_LOCKED, 0, MSG_DELETED, -- 1.6.3.3 From 915e9e0d0a9155e87b7fd414b4da1ddb2470e3fb Mon Sep 17 00:00:00 2001 From: Fabian Keil Date: Sun, 5 Jul 2009 12:36:05 +0200 Subject: [PATCH 68/68] Remove dead stores in compose_entry_append(). XXX: This could be seen as inconsistency. --- src/compose.c | 2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/src/compose.c b/src/compose.c index 615d629..fa4f07b 100644 --- a/src/compose.c +++ b/src/compose.c @@ -2431,8 +2431,6 @@ void compose_entry_append(Compose *compose, const gchar *address, gchar *tmp = g_strdup(begin); gchar *o_tmp = tmp; tmp[cur-begin]='\0'; - cur++; - begin = cur; while (*tmp == ' ' || *tmp == '\t') tmp++; compose_add_header_entry(compose, header, tmp); -- 1.6.3.3